added support for setting and getting clipHighlightToContent#49
Open
marbelsy wants to merge 1 commit intonativescript-community:masterfrom
Open
added support for setting and getting clipHighlightToContent#49marbelsy wants to merge 1 commit intonativescript-community:masterfrom
marbelsy wants to merge 1 commit intonativescript-community:masterfrom
Conversation
Member
|
@mBaldasty actually this is not needed as the property is public ? I have an on going heavy and breaking task to remove all those getter and setter and use properties instead. The idea is to reduce the size of the lib which is pretty big right now. Can you confirm you can still use it without the getter and setter ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist:
PR Description
Added support for getting and setting clipHighlightToContent.
Added function setClipHighlightToContent and isClipHighlightToContentEnabled (same style as as setting the clipping of data and values) in order to allow the highlight to be drawn outside of the content area without bleeding out graphs.
As the variable was already present but lacked the functions to set / get this seemed like a "missing" feature